Skip to content

Set docs workflows in order #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Set docs workflows in order #544

wants to merge 7 commits into from

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Sep 26, 2025 •
edited
Loading

Pre-review checklist

  1. Rename workflow files from .yaml to .yml.
  2. Lock and pull python and poetry version from docs/pyproject.toml.
  3. Adds cache to the workflows.
  4. Changes triggering of the workflows to avoid triggering on unreleated changes.
  5. Small workflow formatting changes.
  6. Don't trigger integration test workflow on docs changes.
  7. Update docs dependencies.
  8. Drop poetry in favor of uv
  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev dkropachev self-assigned this Sep 26, 2025
@dkropachev dkropachev force-pushed the dk/set-docs-workflows-in-order branch from f83c592 to c9a30ad Compare September 26, 2025 14:37
Lorak-mmk
Lorak-mmk requested changes Sep 26, 2025
View reviewed changes
@dkropachev dkropachev force-pushed the dk/set-docs-workflows-in-order branch 3 times, most recently from 9cb5785 to 370c01a Compare September 26, 2025 20:01
Lorak-mmk
Lorak-mmk requested changes Sep 29, 2025
View reviewed changes
@dkropachev dkropachev force-pushed the dk/set-docs-workflows-in-order branch 6 times, most recently from 8972a6c to 5fd18f6 Compare September 29, 2025 20:04
This was referenced Sep 30, 2025
Closed
Closed
Closed
Closed
Closed
@dkropachev
docs: rename workflows to .yml
ff0da4e 
Currently they are .yaml while rest of the workflows are .yml.
Let's set it inline with the rest.
@dkropachev
docs: update workflows triggering conditions
de7d035 
1. Trigger docs PR check on push to master and on PR events when it
   contains relevant changes
2. Include workflow files into triggering conditions
@dkropachev
docs: format workflow files
96a5440
@dkropachev dkropachev force-pushed the dk/set-docs-workflows-in-order branch from 5fd18f6 to 9f26ac0 Compare September 30, 2025 03:41
@dkropachev
docs: update dependencies
0d8432b
@dkropachev
docs: switch from poetry to uv
6b66a76 
uv provides better user experience.
As result of switching form poetry to uv environment preparation became seamless, to the point that `setup` step could have been completely dropped.
@dkropachev
cicd: don't test workflow on docs changes
791f2c8
@dkropachev
docs: set ubuntu-latest runner
b6910e3
@dkropachev dkropachev force-pushed the dk/set-docs-workflows-in-order branch from 9f26ac0 to b6910e3 Compare September 30, 2025 03:55
@dkropachev dkropachev mentioned this pull request Sep 30, 2025
Closed
1 task
@dkropachev
Copy link
Collaborator Author

@Lorak-mmk , can you please rereview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lorak-mmk Lorak-mmk Awaiting requested review from Lorak-mmk

Requested changes must be addressed to merge this pull request.

Assignees

@dkropachev dkropachev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkropachev @Lorak-mmk